Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] oca_publish_modules: tool for publishing modules #409

Merged
merged 4 commits into from
Jun 14, 2020

Conversation

alexey-pelykh
Copy link
Contributor

Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. requires a bit of documentation.
cc @sbidoul @pedrobaeza

tools/oca_publish_modules.py Outdated Show resolved Hide resolved
tools/oca_publish_modules.py Outdated Show resolved Hide resolved
@pedrobaeza
Copy link
Member

I have improved/fixed the flow according my research, but thanks for initial idea, @alexey-pelykh !

@pedrobaeza
Copy link
Member

This is now completed and green.

@pedrobaeza
Copy link
Member

Good news! Rémi Rahir from Odoo has told me several tricks for improving this through JSON endpoints, so I will try soon to implement these suggestions.

@alexey-pelykh
Copy link
Contributor Author

@pedrobaeza at what stage are we on this one?

@pedrobaeza
Copy link
Member

Stalled

@alexey-pelykh
Copy link
Contributor Author

@pedrobaeza maybe let's just continue the work w/o those APIs?

@pedrobaeza
Copy link
Member

Now it's in @simahawk's hands

@simahawk
Copy link
Contributor

@alexey-pelykh @pedrobaeza is not in my hands: if this is something that is working, please, feel free to finish it.
We can use it and if needed we'll find a better solution in the future.
If you think you are too far away from something usable, that's another story :)
What I've done so far is just fixing manually many missing repos.

@alexey-pelykh
Copy link
Contributor Author

@simahawk it was working, then there was a hope for APIs, but I'm not sure if that progressed anywhere. My vision is to rebase this, check that it's still working and do the magic of adopting it. But I need someone to help testing, @pedrobaeza helped me last time and contributed a lot to the original PR

@pedrobaeza
Copy link
Member

Sorry, but I'm not able to do it. Too many hours last time and having our own apps store, I'm personally not making any attention to Odoo's one.

@alexey-pelykh
Copy link
Contributor Author

@pedrobaeza that makes perfect sense, yet I don't really have the means to test it, so unless someone with means will assist (anyone, really), I won't be able to push this forward.

@sbidoul
Copy link
Member

sbidoul commented Mar 17, 2020

@alexey-pelykh I'm not a huge fan of the Odoo app store either but I think it's important OCA is present there too. if you rebase we'll find a way to test it. Either myself, @simahawk or @gurneyalex I guess.

@alexey-pelykh
Copy link
Contributor Author

@sbidoul neither am I, but that's a free marketing :D sure, I'll rebase and let's make some tests

@alexey-pelykh alexey-pelykh force-pushed the imp-oca_publish_modules branch 2 times, most recently from eb50812 to 13493d7 Compare March 17, 2020 16:23
@simahawk
Copy link
Contributor

same story here: if I land on odoo.com is because of clicks on search engine results or shared links 😄
Thanks guys

@simahawk
Copy link
Contributor

simahawk commented Jun 9, 2020

@alexey-pelykh ciao :) Have you found time to make some tests?

@alexey-pelykh
Copy link
Contributor Author

@simahawk nope, @sbidoul mentioned that OCA will find a way to test if I rebase, so I rebased :D and rebased again :D

@sbidoul
Copy link
Member

sbidoul commented Jun 13, 2020

@alexey-pelykh thanks a lot for this. I tweaked it a bit to make it work in the current state of the universe: brainbeanapps#1

I published the current status at https://odoo-community.org/apps.odoo.com/

Make it work with current apps.odoo.com.
- ssh/https url support
- avoid multi-page search results on apps.odoo.com
- some scraper update to match current apps.odoo.com
Assume chromedriver is in path (could not make it work otherwise)
@sbidoul
Copy link
Member

sbidoul commented Jun 13, 2020

tools/publish_modules.py Outdated Show resolved Hide resolved
Co-authored-by: Stéphane Bidoul <[email protected]>
@alexey-pelykh
Copy link
Contributor Author

@sbidoul I would love to, but no such checkbox for me :(

@sbidoul
Copy link
Member

sbidoul commented Jun 14, 2020

Ok, I'll merge then, and we can iterate from here. Thanks a lot!

@sbidoul sbidoul merged commit 2308011 into OCA:master Jun 14, 2020
@sbidoul
Copy link
Member

sbidoul commented Jun 14, 2020

I created #462 and #463 as possible improvements in case anyone feels inspired.

@alexey-pelykh alexey-pelykh deleted the imp-oca_publish_modules branch June 14, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants